I've been rewatching "Silence in the Library"/"Forest of the Dead" and have two questions to discuss, if you like.
One: the only time the Doctor could tell anyone his name - what could he possibly mean? By the look of him, I don't think it's wedding - he looks serious when he realises River knows his name, and she apologizes before she whispers it. It could be death - a real, proper death with no regeneration, and maybe you need the name to build the tomb? (We know it's needed to enter it.) This way River tells the Doctor that at some point, he would be dying and she'd be around, and she wouldn't tell him more, so apologizes make sense.
Second question, and I know it's not been answered properly in the show, just "I made him" in season 7 finale, but I'd like to speculate: when and why did the Doctor tell River his name?[Spoiler to The Husbands of River Song]Was it Twelve at the end of their night? But that would mean he only told her his name because he knew she should know it at their last meeting.
Was it in "Let's Kill Hitler", when she answers "she knows"? It would fit my answer to the first question but she didn't know him well then, she wouldn't know the significance of it and it wasn't exactly time when the Doctor could trust her absolutely. Maybe she's just read the inscription on his craddle in "A God Man Goes To War". But she can't read gallifreyan(?) and the TARDIS doesn't translate it.
Do you have any thoughts? I can live with many plot holes but I love the Library episodes and those two, particularly the first one drive me mad.